Drop deprecated lxd_container and lxd_container_file resources #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
force-pushed
the
drop-lxd_container
branch
8 times, most recently
from
bc5cbac to
ae3a4fb
Compare
Do you plan to create another PR addressing these? |
Not in the short term so I wouldn't delay the |
|
@simondeziel can you rebase this? |
adamcstephens
changed the title
simondeziel
force-pushed
the
drop-lxd_container
branch
from
af86b19 to
90d8394
Compare
Those have been respectively replaced by lxd_instance and lxd_instance_file. This is more consistent because LXD has been supporting VMs in addition to containers since LXD 3.19. Signed-off-by: Simon Deziel <[email protected]>
…ning/ Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
…anceExpandedDevice/ Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
drop-lxd_container
branch
from
90d8394 to
43d0bbc
Compare
|
Added #380 to track the needed deprecations so we don't forget about them. I agree we can handle this post-2.0, and would need to anyway since we still have to have a deprecation cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #348
The
lxd_publish_imageandlxd_snapshotresources still use the legacy namescontainerandcontainer_namebut I left them for another PR.